Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more configuration options for rofi-power #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

more configuration options for rofi-power #1

wants to merge 3 commits into from

Conversation

dennisschuerholz
Copy link

@dennisschuerholz dennisschuerholz commented Feb 19, 2017 •
edited
Loading

As I started using i3 yesterday I came accross your little tool and liked it - thought I wanted some additional configuration options which this pr introduces:

  • config file now overrides defaults as it should be (defaults get set, config is loaded afterwards)
  • options are renameable (configuration file may set e.g. KEYWORD_EXIT, KEYWORD_REBOOT, KEYWORKD_SUSPEND, ...)
  • option order and their presence can be configured (OPTIONS contains placeholder elements, e.g. %EXIT, %REBOOT, %SUSPEND, ...)
  • new option: "lock screen" (KEYWORD_LOCK="Lock screen", placeholder %LOCK)
  • some configuration (OPTIONS (option order), LAUNCHER_OPTIONS, USE_LOCKER and LOCKER) can be overwritten through the calling shell setting ENV_<var> beforehand
  • LAUNCHER gets replaced by static rofi -dmenu -lines $wc (where $wc is the line count through wc -l) followed by the configurable LAUNCHER_OPTIONS as I don't think calling rofi is something that might get replaced while using rofi_power

I have to admin that it almost looks like a complete rewrite, but I hope you might still consider this pr. I will use it like this and assume some others might like it as well.
Best regars, Dennis

@dennisschuerholz
enhanced configuration options
e861b05 
* config file now overrides defaults as it should be
* options are renameable
* option order can be configured
@dennisschuerholz
parent shell might pass some configuration options
5725317
@dennisschuerholz
Adds option to lock from rofi-power
2446e1f
@dennisschuerholz dennisschuerholz mentioned this pull request May 20, 2017
Open
@okraits
Copy link
Owner

okraits commented Jan 3, 2018 •
edited
Loading

Hi @dennisschuerholz, first of all thank you very much for your contribution and sorry for responding so late.

I would like to discuss the various changes:

  • defaults get set, config is loaded afterwards: I like the change and the main advantage for me is that it makes it impossible that variables are not set. One question though: why did you handle the OPTIONS variable differently?
  • renameable and sortable options: I also like this. However, I prefer how @orestisf1993 implemented this as the option name and the command to be executed are defined together. What do you think about this? This also enables the user to add further options.
  • new option "lock screen": I use a keybind to call i3lock but I'm ok with adding this option.
  • overriding configuration through environment variables: what's your usecase for that? We already have a config file so I don't see any sense in overriding that further more.
  • LAUNCHER_OPTIONS: my intention for LAUNCHER was not to make rofi replaceable but to enable the user to completely customize the arguments for calling rofi. So your way of using LAUNCHER_OPTIONS is basically the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisschuerholz @okraits